fix pointer style to match the style guide

We do this in a lot of places, but we're inconsistent.
Normalize the code to the Google C++ style guide.

Change-Id: Ic2aceab661ce8f6b993dda21b1cdf5d2198dcbbf
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2262932
Reviewed-by: Sterling Augustine <saugustine@google.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Mike Frysinger
2020-06-23 18:55:43 -04:00
parent a741027533
commit 09b056975d
289 changed files with 3770 additions and 3775 deletions

View File

@@ -48,9 +48,9 @@ namespace google_breakpad {
#endif
template<typename V>
bool CFIFrameInfo::FindCallerRegs(const RegisterValueMap<V> &registers,
const MemoryRegion &memory,
RegisterValueMap<V> *caller_registers) const {
bool CFIFrameInfo::FindCallerRegs(const RegisterValueMap<V>& registers,
const MemoryRegion& memory,
RegisterValueMap<V>* caller_registers) const {
// If there are not rules for both .ra and .cfa in effect at this address,
// don't use this CFI data for stack walking.
if (cfa_rule_.empty() || ra_rule_.empty())
@@ -93,13 +93,13 @@ bool CFIFrameInfo::FindCallerRegs(const RegisterValueMap<V> &registers,
// Explicit instantiations for 32-bit and 64-bit architectures.
template bool CFIFrameInfo::FindCallerRegs<uint32_t>(
const RegisterValueMap<uint32_t> &registers,
const MemoryRegion &memory,
RegisterValueMap<uint32_t> *caller_registers) const;
const RegisterValueMap<uint32_t>& registers,
const MemoryRegion& memory,
RegisterValueMap<uint32_t>* caller_registers) const;
template bool CFIFrameInfo::FindCallerRegs<uint64_t>(
const RegisterValueMap<uint64_t> &registers,
const MemoryRegion &memory,
RegisterValueMap<uint64_t> *caller_registers) const;
const RegisterValueMap<uint64_t>& registers,
const MemoryRegion& memory,
RegisterValueMap<uint64_t>* caller_registers) const;
string CFIFrameInfo::Serialize() const {
std::ostringstream stream;
@@ -123,7 +123,7 @@ string CFIFrameInfo::Serialize() const {
return stream.str();
}
bool CFIRuleParser::Parse(const string &rule_set) {
bool CFIRuleParser::Parse(const string& rule_set) {
size_t rule_set_len = rule_set.size();
scoped_array<char> working_copy(new char[rule_set_len + 1]);
memcpy(working_copy.get(), rule_set.data(), rule_set_len);
@@ -132,9 +132,9 @@ bool CFIRuleParser::Parse(const string &rule_set) {
name_.clear();
expression_.clear();
char *cursor;
char* cursor;
static const char token_breaks[] = " \t\r\n";
char *token = strtok_r(working_copy.get(), token_breaks, &cursor);
char* token = strtok_r(working_copy.get(), token_breaks, &cursor);
for (;;) {
// End of rule set?
@@ -170,16 +170,16 @@ bool CFIRuleParser::Report() {
return true;
}
void CFIFrameInfoParseHandler::CFARule(const string &expression) {
void CFIFrameInfoParseHandler::CFARule(const string& expression) {
frame_info_->SetCFARule(expression);
}
void CFIFrameInfoParseHandler::RARule(const string &expression) {
void CFIFrameInfoParseHandler::RARule(const string& expression) {
frame_info_->SetRARule(expression);
}
void CFIFrameInfoParseHandler::RegisterRule(const string &name,
const string &expression) {
void CFIFrameInfoParseHandler::RegisterRule(const string& name,
const string& expression) {
frame_info_->SetRegisterRule(name, expression);
}