SwitchEmu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-02-19 00:39:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

[breakpad] Add MINIDUMP_THREAD_NAME_LIST support

Browse Source 
Change-Id: I84205358ae48e757fa3b836747eadc32c2671756
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3690389
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
This commit is contained in:
Ben Hamilton
2022-06-06 19:01:15 -06:00
committed by Joshua Peraza
parent 737e2cd338
commit 4d85225467
10 changed files with 399 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/processor/minidump_processor.cc
View File

@@ -32,7 +32,9 @@
#include <assert.h>
#include <algorithm>
#include <map>
#include <string>
#include <utility>
#include "common/scoped_ptr.h"
#include "common/stdio_wrapper.h"
@@ -199,6 +201,28 @@ ProcessResult MinidumpProcessor::Process(
// Reset frame_symbolizer_ at the beginning of stackwalk for each minidump.
frame_symbolizer_->Reset();
MinidumpThreadNameList* thread_names = dump->GetThreadNameList();
std::map<uint32_t, string> thread_id_to_name;
if (thread_names) {
const unsigned int thread_name_count = thread_names->thread_name_count();
for (unsigned int thread_name_index = 0;
thread_name_index < thread_name_count;
++thread_name_index) {
MinidumpThreadName* thread_name = thread_names->GetThreadNameAtIndex(thread_name_index);
if (!thread_name) {
BPLOG(ERROR) << "Could not get thread name for thread at index " << thread_name_index;
return PROCESS_ERROR_GETTING_THREAD_NAME;
}
uint32_t thread_id;
if (!thread_name->GetThreadID(&thread_id)) {
BPLOG(ERROR) << "Could not get thread ID for thread at index " << thread_name_index;
return PROCESS_ERROR_GETTING_THREAD_NAME;
}
thread_id_to_name.insert(std::make_pair(thread_id, thread_name->GetThreadName()));
}
}
for (unsigned int thread_index = 0;
thread_index < thread_count;
++thread_index) {
@@ -220,6 +244,14 @@ ProcessResult MinidumpProcessor::Process(
}
thread_string += " id " + HexString(thread_id);
auto thread_name_iter = thread_id_to_name.find(thread_id);
string thread_name;
if (thread_name_iter != thread_id_to_name.end()) {
thread_name = thread_name_iter->second;
}
if (!thread_name.empty()) {
thread_string += " name [" + thread_name + "]";
}
BPLOG(INFO) << "Looking at thread " << thread_string;
// If this thread is the thread that produced the minidump, don't process
@@ -311,6 +343,7 @@ ProcessResult MinidumpProcessor::Process(
stack->set_tid(thread_id);
process_state->threads_.push_back(stack.release());
process_state->thread_memory_regions_.push_back(thread_memory);
process_state->thread_names_.push_back(thread_name);
}
if (interrupted) {