SwitchEmu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-03-07 04:36:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor the Windows MinidumpGenerator interface to get rid of the overloads when generating dumps.

Browse Source 
All required params are now passed to the constructor and the various options are set through new methods.

BUG=N/A
TEST=Existing minidump generation tests
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/1074002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1274 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
cdn@chromium.org
2014-01-17 22:39:11 +00:00
parent d9f582edce
commit 8b65346242
5 changed files with 262 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/client/windows/unittests/minidump_test.cc
View File

@@ -104,19 +104,19 @@ class MinidumpTest: public testing::Test {
&ctx_record,
};
MinidumpGenerator generator(dump_path_);
MinidumpGenerator generator(dump_path_,
::GetCurrentProcess(),
::GetCurrentProcessId(),
::GetCurrentThreadId(),
::GetCurrentThreadId(),
&ex_ptrs,
NULL,
static_cast<MINIDUMP_TYPE>(flags),
TRUE);
generator.GenerateDumpFile(&dump_file_);
generator.GenerateFullDumpFile(&full_dump_file_);
// And write a dump
bool result = generator.WriteMinidump(::GetCurrentProcess(),
::GetCurrentProcessId(),
::GetCurrentThreadId(),
::GetCurrentThreadId(),
&ex_ptrs,
NULL,
static_cast<MINIDUMP_TYPE>(flags),
TRUE,
&dump_file_,
&full_dump_file_);
bool result = generator.WriteMinidump();
return result == TRUE;
}