SwitchEmu/breakpad
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/breakpad.git synced 2026-02-25 10:12:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add the TID to the CallStack.

Browse Source 
R=ivanpe@chromium.org

Review URL: https://codereview.chromium.org/1849933002 .
This commit is contained in:
Sebastien Marchand
2016-04-01 10:11:10 -04:00
parent c77c51fae6
commit d9c532217e
4 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/processor/call_stack.cc
View File

@@ -48,6 +48,7 @@ void CallStack::Clear() {
++iterator) {
delete *iterator;
}
tid_ = 0;
}
} // namespace google_breakpad

1
src/processor/minidump_processor.cc
View File

@@ -267,6 +267,7 @@ ProcessResult MinidumpProcessor::Process(
// one bad thread.
BPLOG(ERROR) << "No stackwalker for " << thread_string;
}
stack->set_tid(thread_id);
process_state->threads_.push_back(stack.release());
process_state->thread_memory_regions_.push_back(thread_memory);
}

1
src/processor/minidump_processor_unittest.cc
View File

@@ -414,6 +414,7 @@ TEST_F(MinidumpProcessorTest, TestBasicProcessing) {
ASSERT_EQ(state.crash_reason(), "EXCEPTION_ACCESS_VIOLATION_WRITE");
ASSERT_EQ(state.crash_address(), 0x45U);
ASSERT_EQ(state.threads()->size(), size_t(1));
EXPECT_EQ((*state.threads())[0]->tid(), 3060);
ASSERT_EQ(state.requesting_thread(), 0);
EXPECT_EQ(1171480435U, state.time_date_stamp());
EXPECT_EQ(1171480435U, state.process_create_time());