Mike Frysinger
2b7724245b
windows: fix build on pre-Win10 systems
...
The use of DBG_PRINTEXCEPTION_WIDE_C was added for Win10 support,
but that define doesn't exist in older versions which means we fail
to build. Put it behind an ifdef check to work everywhere.
Change-Id: Ibab8bddd5c19b4b50e356f59edeb3873c3104569
Reviewed-on: https://chromium-review.googlesource.com/441525
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-02-11 22:36:18 +00:00
Mike Frysinger
12f8ca4855
windows: update gtest/gmock paths
...
The Windows build has rotted a bit with the gtest/gmock updates.
Update all of the paths to fix things up again.
Change-Id: Id67ce76abfd331c0543aa4bd1138e9cc13a18c75
Reviewed-on: https://chromium-review.googlesource.com/441584
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-02-11 18:03:31 +00:00
Tim Angus
6b2f69dd10
Also treat DBG_PRINTEXCEPTION* as debug exceptions
...
Windows 10 now raises an exception when OutputDebugString* are called:
(https://ntquery.wordpress.com/2015/09/07/windows-10-new-anti-debug-outputdebugstringw/ )
This change ignores these exception types such that they're not falsely
identified as a crash.
BUG=
Change-Id: I1326212662d46e16407681d5ea6377f63ee188ce
Reviewed-on: https://chromium-review.googlesource.com/398998
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-10-18 18:08:24 +00:00
Rafal Chlodnicki
a2196179cc
Fix breakpad compilation issue with clang on Windows
...
Fix unused variable error. Code that uses the kWaitForHandlerThreadMs
constant is inside and ifdef so in some compile configurations constant
was unused. Move it where it's used.
And do the same with other constants as requested during review.
BUG=
Change-Id: I4f4c8f36c982092d53438ed6d2a0a97772402d69
Reviewed-on: https://chromium-review.googlesource.com/374378
Reviewed-by: Mark Mentovai <mark@chromium.org>
2016-08-25 21:43:05 +00:00
Ting-Yu Chou
dfd2da7979
Add a new argument to specify the minidump type to write on Windows.
...
R=ted.mielczarek@gmail.com
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1267329
Review URL: https://codereview.chromium.org/2107083002/ .
2016-06-29 06:48:26 -04:00
Ted Mielczarek
4ee6f3cd1c
Fix Windows crash_generation_server for debug builds without -D_DEBUG
...
Debug Gecko builds don't build with -D_DEBUG, so the ifdef in
crash_generation_server doesn't work right. The MSDN documentation for
assert says that it's enabled based on the absence of the NDEBUG define,
so using that seems sensible.
R=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1398453002 .
2015-10-07 14:19:23 -04:00
David Major
7685dfc567
Support for multiple upload files in CrashReportSender/HTTPUpload
...
A=David Major <dmajor@mozilla.com>
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1048091
R=ted@mielczarek.org
Review URL: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091 .
2015-10-06 11:05:12 -04:00
Ted Mielczarek
dbf56c53a0
Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013.
...
The Windows client gyp files were missing proc_maps_linux.cc for the
unittest build. Adding that revealed some build errors due to it
unconditionally including <inttypes.h>. Removing the workarounds in
breakpad_types.h (and a few other places) made that build, which means
that Visual C++ 2013 is now our minimum supported version of MSVC.
Additionally I tried building with VC++ 2015 and fixed a few warnings
(which were failing the build because we have /WX enabled) to ensure
that that builds as well.
BUG=https://code.google.com/p/google-breakpad/issues/detail?id=669
R=mark@chromium.org
Review URL: https://codereview.chromium.org/1353893002 .
2015-10-06 08:03:57 -04:00
wfh@chromium.org
0c426387b8
Fix -Wreorder warnings in the Windows code.
...
This makes the order of fields in constructor initializer lists match
the order in which the fields are declared in (which is the order
they're initialized in). No intended behavior change.
This change was originally reviewed at
https://codereview.chromium.org/1230923005/
BUG=chromium:505304
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1234653002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1471 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-07-10 20:24:33 +00:00
ted.mielczarek@gmail.com
48b9a40539
Fix compilation with gcc --std=c++11
...
Patch by Jon Turney <jon.turney.1111@gmail.com>
R=ted at https://breakpad.appspot.com/7824002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1435 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-03-24 11:25:14 +00:00
wfh@chromium.org
b79454627e
Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions.
...
BUG=chromium:452613
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/7794002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1427 4c0a9323-5329-0410-9bdc-e9ce6186880e
2015-02-22 02:27:35 +00:00
ted.mielczarek@gmail.com
c971cf439c
Fix Windows client compilation on mingw.
...
A=Jacek Caban <jacek@codeweavers.com>, R=ted at http://breakpad.appspot.com/548002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1399 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-11-03 17:05:39 +00:00
ivanpe@chromium.org
962f1b0e60
The process uptime computation when the Windows out-of-process Crash Generation
...
Server is used is done by subtracting the crashing process creation time from
the current time when the crash is generated:
uptime = now - process_creation_time
There was a bug and instead of the process creation time the code was using the
time when the process was registered with the Crash Generation Server.
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1744002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1391 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-10-15 17:15:55 +00:00
mmandlis@chromium.org
85cc448052
Fix Windows client unittests build: add missing code files
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1377 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-09-16 19:17:19 +00:00
mark@chromium.org
a58de86bcd
Back out trunk r1367.
...
Compile error: https://bugzilla.mozilla.org/show_bug.cgi?id=1048091#c15
Review URL: https://breakpad.appspot.com/9694002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1369 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-09-03 13:40:40 +00:00
ted.mielczarek@gmail.com
8cde5c5152
Support for multiple upload files in CrashReportSender/HTTPUpload
...
A=David Major <dmajor@mozilla.com> R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=1048091
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1367 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-08-28 15:26:59 +00:00
ted.mielczarek@gmail.com
d7d532bf56
Ensure C:/Dumps/ exists in crash_generation_app
...
A=j.turney
R=ted at https://breakpad.appspot.com/1134002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1348 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-07-11 18:48:41 +00:00
ivan.penkov@gmail.com
7dbca422d4
Moving directory 'build' one level up as it collides with a file named 'BUILD' which happens to be in that same location in the Google source depot.
...
R=chrisha@chromium.org , mark@chromium.org
Review URL: https://breakpad.appspot.com/1504002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1308 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-10 17:37:20 +00:00
chrisha@chromium.org
611f8b7f32
Move build configuration to root of repository.
...
This is in preparation for creating GYP build files for each platform.
BUG=https://code.google.com/p/google-breakpad/issues/detail?id=575
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1414002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1304 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-04-03 18:34:24 +00:00
wfh@chromium.org
3e12c58449
Ignore warning 4702 to avoid unreachable code error on
...
VS2013 stl when compiling with _HAS_EXCEPTIONS=0
See also https://crbug.com/346399 for background.
BUG=540
R=mark@chromium.org , thestig@chromium.org
TEST=update gyp to HEAD, generate MSVS2013 build files, verify breakpad compiles in Release.
Review URL: https://breakpad.appspot.com/1284002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1292 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-03-26 21:02:12 +00:00
thestig@chromium.org
b764582a53
Fix crash in Windows CrashGenerationServer from r1274.
...
R=cdn@chromium.org , mark@chromium.org
Review URL: https://breakpad.appspot.com/1254002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1289 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-03-19 19:12:56 +00:00
thestig@chromium.org
c590a7f322
Windows: Fix 64-bit compitation of crash_generation_app.
...
BUG=560
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1104002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1276 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-01-21 19:22:37 +00:00
cdn@chromium.org
8b65346242
Refactor the Windows MinidumpGenerator interface to get rid of the overloads when generating dumps.
...
All required params are now passed to the constructor and the various options are set through new methods.
BUG=N/A
TEST=Existing minidump generation tests
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1074002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1274 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-01-17 22:39:11 +00:00
cdn@chromium.org
d9f582edce
Fix VS project generation for the crash generation app.
...
BUG=N/A
TEST=N/A
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/1084002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1273 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-01-17 21:57:47 +00:00
thestig@chromium.org
53a689933f
Run svn propdel svn:executable on source code files.
...
Review URL: https://breakpad.appspot.com/934002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1263 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-17 21:40:50 +00:00
thestig@chromium.org
a4d055f1c2
Fix error r1258.
...
BUG=556
R=cdn@chromium.org , mark@chromium.org
Review URL: https://breakpad.appspot.com/904004
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1262 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-17 19:04:11 +00:00
cdn@chromium.org
4bcf51dc79
Expose the ability to supply additional user streams in the windows dump generator.
...
BUG=N/A
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/894002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1258 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-12 20:04:42 +00:00
vapier@chromium.org
4c048c9764
disable unittests under ASAN that use memory crashes
...
There are a bunch of tests that use invalid memory acesses (on purpose)
to trigger a crash so that we can detect things are dumped correctly.
When we run under ASAN, it catches those accesses and the breaks the
testing flow.
For now, use the existing ADDRESS_SANITIZER symbol to disable more tests.
Ideally we'd use a compile-time attribute to disable ASAN on a few funcs,
but that seems to be broken atm.
BUG=chromium:293519
BUG=chromium:304575
TEST=ran unittests under ASAN and they now pass
TEST=ran unittests w/out asan/clang and they still pass
R=benchan@chromium.org
Review URL: https://breakpad.appspot.com/884002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1255 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-11 05:38:34 +00:00
thestig@chromium.org
8d22ec9227
Fix Windows release build error due to unreferenced variables.
...
BUG=544
R=mark@chromium.org
Review URL: https://breakpad.appspot.com/874002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1249 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-09 21:59:48 +00:00
mark@chromium.org
186f1cb206
Switch armv7 setting to arm_version==7.
...
Patch by Mostyn Bramley-Moore <mostynb@opera.com>
BUG=chromium:234135
Review URL: https://breakpad.appspot.com/844002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1246 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-12-08 19:28:36 +00:00
cdn@chromium.org
8041deee0c
add interface for WriteMinidump which allows the caller to supply file handles instead of paths where the minidumps should be written.
...
BUG=N/A
TEST=N/A
R=ivan.penkov@gmail.com , mark@chromium.org
Review URL: https://breakpad.appspot.com/602002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1191 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-06-06 17:20:34 +00:00
ivan.penkov@gmail.com
6b46d4e872
Treat warnings as error and fix most level 4 warnings in the breakpad windows client projects.
...
Some of the lint errors in the files touched by this change were also fixed.
BUG=533
Review URL: https://breakpad.appspot.com/601002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1189 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-06-04 16:51:01 +00:00
ivan.penkov@gmail.com
e4d3cca3ef
Submitting this on behalf of Xiaoling Bao.
...
Make custom info population before dump generation as an optional operation. This is part of a security change to move the crash generation and upload out of Google updater process.
Review URL: https://breakpad.appspot.com/586003
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1186 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-05-20 18:55:54 +00:00
ivan.penkov@gmail.com
40c9de4d8d
Allow option for efficient and safe opt out of in-proc dump generation for Windows breakpad clients.
...
https://breakpad.appspot.com/549002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1157 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-04-23 00:47:53 +00:00
ted.mielczarek@gmail.com
cd0eb0f8dc
Fix Windows unittest build on VC2012
...
R=mark at https://breakpad.appspot.com/539003/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1133 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-03-29 14:39:55 +00:00
ted.mielczarek@gmail.com
e88f61c7ba
Remove "library" variable
...
A=Thiago Farina <tfarina@chromium.org>
BUG=http://code.google.com/p/chromium/issues/detail?id=111541
R=thestig@chromium.org at https://breakpad.appspot.com/537002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1130 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-03-07 19:02:46 +00:00
ted.mielczarek@gmail.com
aeffe1056f
Use stdint types everywhere
...
R=mark at https://breakpad.appspot.com/535002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1121 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-03-06 14:04:42 +00:00
thestig@chromium.org
d2153d7589
Fix remaining processor/scoped_ptr.h references for reals.
...
Review URL: https://breakpad.appspot.com/516003
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1104 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-01-22 18:49:58 +00:00
thestig@chromium.org
1c4f4a776c
Fix remaining processor/scoped_ptr.h references after r1096.
...
Review URL: https://breakpad.appspot.com/516002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1103 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-01-22 17:20:42 +00:00
thestig@chromium.org
834f7ee611
Remove <(library) usage from gyp files.
...
BUG=chromium:111541
Patch by Thiago Farina <tfarina@chromium.org>.
Original code review: https://breakpad.appspot.com/513002/
Review URL: https://breakpad.appspot.com/515002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1101 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-01-19 00:19:16 +00:00
ted.mielczarek@gmail.com
63c5d98003
Move scoped_ptr.h to common
...
R=mark at https://breakpad.appspot.com/509002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1096 4c0a9323-5329-0410-9bdc-e9ce6186880e
2013-01-17 15:53:56 +00:00
ivan.penkov@gmail.com
6b91f41a7c
SuspendThread returns a DWORD value, so checking the return value with ">= 0"
...
doesn't work. On failure, the return value is (DWORD) -1 (which is
0xFFFFFFFF).
http://breakpad.appspot.com/491002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1075 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-11-01 21:49:06 +00:00
ivan.penkov@gmail.com
df8e3973f4
Fixing Windows client unit tests. They were broken in r1034 due to gMock and
...
gTest upgrade. While fixing the broken tests I also used the opportunity to add
a few more tests that cover filter and callback execution, and nesting of
exception handlers.
https://breakpad.appspot.com/489002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1073 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-10-19 18:51:05 +00:00
ted.mielczarek@gmail.com
3500120c1f
Fix a really stupid bug in WriteMinidumpForChildProcess
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1047 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-09-24 18:36:34 +00:00
ted.mielczarek@gmail.com
6a5ab68d56
Allow generating minidumps from live processes on Windows.
...
R=mark at https://breakpad.appspot.com/115002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1042 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-09-18 13:55:17 +00:00
ted.mielczarek@gmail.com
61d9b9ff96
Allow adding extra memory regions to minidump on linux/windows
...
A=Bill McCloskey <wmccloskey@mozilla.com>, ted, original patch from https://bugzilla.mozilla.org/show_bug.cgi?id=662646
R=mark at https://breakpad.appspot.com/450002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1041 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-09-18 13:54:58 +00:00
ted.mielczarek@gmail.com
52935b4e81
Add a GetInstructionPointer method to MinidumpException
...
R=mark at https://breakpad.appspot.com/444003/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1039 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-09-17 14:01:28 +00:00
ivan.penkov@gmail.com
d6a10e6fbb
Fix of a race condition during Crash Generation Server startup
...
https://breakpad.appspot.com/445002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1031 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-09-07 18:01:26 +00:00
ivan.penkov@gmail.com
e050c46a53
Fixing a Windows compiler warning in src/client/windows/crash_generation/minidump_generator.cc
...
http://breakpad.appspot.com/432002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1014 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-08-17 01:41:05 +00:00
ivan.penkov@gmail.com
d7de392b05
Fixing a race condition in the Crash Generation Server which has to
...
do with simultaneous handling of dump requests and client process
termination events.
http://breakpad.appspot.com/430002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1013 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-08-15 22:09:42 +00:00