mirror of
https://git.suyu.dev/suyu/breakpad.git
synced 2026-02-06 05:24:02 +00:00
Added
#ifdef HAVE_CONFIG_H
#include <config.h>
#endif
to the beginning of all source files that didn't have it.
This ensures that configuration options are respected in all source
files. In particular, it ensures that the defines needed to fix Large
File System issues are set before including system headers.
More generally, it ensures consistency between the source files, and
avoids the possibility of ODR violations between source files that were
including config.h and source files that were not.
Process:
Ran
find . \( -name third_party -prune \) -o \( -name '.git*' -prune \) -o \( \( -name '*.cc' -o -name '*.c' \) -exec sed -i '0,/^#include/ s/^#include/#ifdef HAVE_CONFIG_H\n#include <config.h> \/\/ Must come first\n#endif\n\n#include/' {} + \)
and then manually fixed up src/common/linux/guid_creator.cc,
src/tools/solaris/dump_syms/testdata/dump_syms_regtest.cc,
src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc,
src/common/stabs_reader.h, and src/common/linux/breakpad_getcontext.h.
BUG=google-breakpad:877
Fixed: google-breakpad:877
TEST=./configure && make && make check
TEST=Did the find/sed in ChromeOS's copy, ensured emerge-hana google-breakpad
worked and had fewer LFS violations.
TEST=Did the find/sed in Chrome's copy, ensured compiling hana, windows, linux, and
eve still worked (since Chrome doesn't used config.h)
Change-Id: I16cededbba0ea0c28e919b13243e35300999e799
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4289676
Reviewed-by: Mike Frysinger <vapier@chromium.org>
343 lines
11 KiB
C++
343 lines
11 KiB
C++
// Copyright 2008 Google LLC
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following disclaimer
|
|
// in the documentation and/or other materials provided with the
|
|
// distribution.
|
|
// * Neither the name of Google LLC nor the names of its
|
|
// contributors may be used to endorse or promote products derived from
|
|
// this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
#include <config.h> // Must come first
|
|
#endif
|
|
|
|
#include "breakpad_googletest_includes.h"
|
|
#include "common/simple_string_dictionary.h"
|
|
|
|
namespace google_breakpad {
|
|
|
|
TEST(NonAllocatingMapTest, Entry) {
|
|
typedef NonAllocatingMap<5, 9, 15> TestMap;
|
|
TestMap map;
|
|
|
|
const TestMap::Entry* entry = TestMap::Iterator(map).Next();
|
|
EXPECT_FALSE(entry);
|
|
|
|
// Try setting a key/value and then verify.
|
|
map.SetKeyValue("key1", "value1");
|
|
entry = TestMap::Iterator(map).Next();
|
|
ASSERT_TRUE(entry);
|
|
EXPECT_STREQ(entry->key, "key1");
|
|
EXPECT_STREQ(entry->value, "value1");
|
|
|
|
// Try setting a new value.
|
|
map.SetKeyValue("key1", "value3");
|
|
EXPECT_STREQ(entry->value, "value3");
|
|
|
|
// Make sure the key didn't change.
|
|
EXPECT_STREQ(entry->key, "key1");
|
|
|
|
// Clear the entry and verify the key and value are empty strings.
|
|
map.RemoveKey("key1");
|
|
EXPECT_FALSE(entry->is_active());
|
|
EXPECT_EQ(strlen(entry->key), 0u);
|
|
EXPECT_EQ(strlen(entry->value), 0u);
|
|
}
|
|
|
|
TEST(NonAllocatingMapTest, SimpleStringDictionary) {
|
|
// Make a new dictionary
|
|
SimpleStringDictionary dict;
|
|
|
|
// Set three distinct values on three keys
|
|
dict.SetKeyValue("key1", "value1");
|
|
dict.SetKeyValue("key2", "value2");
|
|
dict.SetKeyValue("key3", "value3");
|
|
|
|
EXPECT_NE(dict.GetValueForKey("key1"), "value1");
|
|
EXPECT_NE(dict.GetValueForKey("key2"), "value2");
|
|
EXPECT_NE(dict.GetValueForKey("key3"), "value3");
|
|
EXPECT_EQ(dict.GetCount(), 3u);
|
|
// try an unknown key
|
|
EXPECT_FALSE(dict.GetValueForKey("key4"));
|
|
|
|
// Remove a key
|
|
dict.RemoveKey("key3");
|
|
|
|
// Now make sure it's not there anymore
|
|
EXPECT_FALSE(dict.GetValueForKey("key3"));
|
|
|
|
// Remove by setting value to NULL
|
|
dict.SetKeyValue("key2", NULL);
|
|
|
|
// Now make sure it's not there anymore
|
|
EXPECT_FALSE(dict.GetValueForKey("key2"));
|
|
}
|
|
|
|
TEST(NonAllocatingMapTest, CopyAndAssign) {
|
|
NonAllocatingMap<10, 10, 10> map;
|
|
map.SetKeyValue("one", "a");
|
|
map.SetKeyValue("two", "b");
|
|
map.SetKeyValue("three", "c");
|
|
map.RemoveKey("two");
|
|
EXPECT_EQ(2u, map.GetCount());
|
|
|
|
// Test copy.
|
|
NonAllocatingMap<10, 10, 10> map_copy(map);
|
|
EXPECT_EQ(2u, map_copy.GetCount());
|
|
EXPECT_STREQ("a", map_copy.GetValueForKey("one"));
|
|
EXPECT_STREQ("c", map_copy.GetValueForKey("three"));
|
|
map_copy.SetKeyValue("four", "d");
|
|
EXPECT_STREQ("d", map_copy.GetValueForKey("four"));
|
|
EXPECT_FALSE(map.GetValueForKey("four"));
|
|
|
|
// Test assign.
|
|
NonAllocatingMap<10, 10, 10> map_assign;
|
|
map_assign = map;
|
|
EXPECT_EQ(2u, map_assign.GetCount());
|
|
EXPECT_STREQ("a", map_assign.GetValueForKey("one"));
|
|
EXPECT_STREQ("c", map_assign.GetValueForKey("three"));
|
|
map_assign.SetKeyValue("four", "d");
|
|
EXPECT_STREQ("d", map_assign.GetValueForKey("four"));
|
|
EXPECT_FALSE(map.GetValueForKey("four"));
|
|
|
|
map.RemoveKey("one");
|
|
EXPECT_FALSE(map.GetValueForKey("one"));
|
|
EXPECT_STREQ("a", map_copy.GetValueForKey("one"));
|
|
EXPECT_STREQ("a", map_assign.GetValueForKey("one"));
|
|
}
|
|
|
|
// Add a bunch of values to the dictionary, remove some entries in the middle,
|
|
// and then add more.
|
|
TEST(NonAllocatingMapTest, Iterator) {
|
|
SimpleStringDictionary* dict = new SimpleStringDictionary();
|
|
ASSERT_TRUE(dict);
|
|
|
|
char key[SimpleStringDictionary::key_size];
|
|
char value[SimpleStringDictionary::value_size];
|
|
|
|
const int kDictionaryCapacity = SimpleStringDictionary::num_entries;
|
|
const int kPartitionIndex = kDictionaryCapacity - 5;
|
|
|
|
// We assume at least this size in the tests below
|
|
ASSERT_GE(kDictionaryCapacity, 64);
|
|
|
|
// We'll keep track of the number of key/value pairs we think should
|
|
// be in the dictionary
|
|
int expectedDictionarySize = 0;
|
|
|
|
// Set a bunch of key/value pairs like key0/value0, key1/value1, ...
|
|
for (int i = 0; i < kPartitionIndex; ++i) {
|
|
sprintf(key, "key%d", i);
|
|
sprintf(value, "value%d", i);
|
|
dict->SetKeyValue(key, value);
|
|
}
|
|
expectedDictionarySize = kPartitionIndex;
|
|
|
|
// set a couple of the keys twice (with the same value) - should be nop
|
|
dict->SetKeyValue("key2", "value2");
|
|
dict->SetKeyValue("key4", "value4");
|
|
dict->SetKeyValue("key15", "value15");
|
|
|
|
// Remove some random elements in the middle
|
|
dict->RemoveKey("key7");
|
|
dict->RemoveKey("key18");
|
|
dict->RemoveKey("key23");
|
|
dict->RemoveKey("key31");
|
|
expectedDictionarySize -= 4; // we just removed four key/value pairs
|
|
|
|
// Set some more key/value pairs like key59/value59, key60/value60, ...
|
|
for (int i = kPartitionIndex; i < kDictionaryCapacity; ++i) {
|
|
sprintf(key, "key%d", i);
|
|
sprintf(value, "value%d", i);
|
|
dict->SetKeyValue(key, value);
|
|
}
|
|
expectedDictionarySize += kDictionaryCapacity - kPartitionIndex;
|
|
|
|
// Now create an iterator on the dictionary
|
|
SimpleStringDictionary::Iterator iter(*dict);
|
|
|
|
// We then verify that it iterates through exactly the number of
|
|
// key/value pairs we expect, and that they match one-for-one with what we
|
|
// would expect. The ordering of the iteration does not matter...
|
|
|
|
// used to keep track of number of occurrences found for key/value pairs
|
|
int count[kDictionaryCapacity];
|
|
memset(count, 0, sizeof(count));
|
|
|
|
int totalCount = 0;
|
|
|
|
const SimpleStringDictionary::Entry* entry;
|
|
while ((entry = iter.Next())) {
|
|
totalCount++;
|
|
|
|
// Extract keyNumber from a string of the form key<keyNumber>
|
|
int keyNumber;
|
|
sscanf(entry->key, "key%d", &keyNumber);
|
|
|
|
// Extract valueNumber from a string of the form value<valueNumber>
|
|
int valueNumber;
|
|
sscanf(entry->value, "value%d", &valueNumber);
|
|
|
|
// The value number should equal the key number since that's how we set them
|
|
EXPECT_EQ(keyNumber, valueNumber);
|
|
|
|
// Key and value numbers should be in proper range:
|
|
// 0 <= keyNumber < kDictionaryCapacity
|
|
bool isKeyInGoodRange =
|
|
(keyNumber >= 0 && keyNumber < kDictionaryCapacity);
|
|
bool isValueInGoodRange =
|
|
(valueNumber >= 0 && valueNumber < kDictionaryCapacity);
|
|
EXPECT_TRUE(isKeyInGoodRange);
|
|
EXPECT_TRUE(isValueInGoodRange);
|
|
|
|
if (isKeyInGoodRange && isValueInGoodRange) {
|
|
++count[keyNumber];
|
|
}
|
|
}
|
|
|
|
// Make sure each of the key/value pairs showed up exactly one time, except
|
|
// for the ones which we removed.
|
|
for (size_t i = 0; i < kDictionaryCapacity; ++i) {
|
|
// Skip over key7, key18, key23, and key31, since we removed them
|
|
if (!(i == 7 || i == 18 || i == 23 || i == 31)) {
|
|
EXPECT_EQ(count[i], 1);
|
|
}
|
|
}
|
|
|
|
// Make sure the number of iterations matches the expected dictionary size.
|
|
EXPECT_EQ(totalCount, expectedDictionarySize);
|
|
}
|
|
|
|
|
|
TEST(NonAllocatingMapTest, AddRemove) {
|
|
NonAllocatingMap<5, 7, 6> map;
|
|
map.SetKeyValue("rob", "ert");
|
|
map.SetKeyValue("mike", "pink");
|
|
map.SetKeyValue("mark", "allays");
|
|
|
|
EXPECT_EQ(3u, map.GetCount());
|
|
EXPECT_STREQ("ert", map.GetValueForKey("rob"));
|
|
EXPECT_STREQ("pink", map.GetValueForKey("mike"));
|
|
EXPECT_STREQ("allays", map.GetValueForKey("mark"));
|
|
|
|
map.RemoveKey("mike");
|
|
|
|
EXPECT_EQ(2u, map.GetCount());
|
|
EXPECT_FALSE(map.GetValueForKey("mike"));
|
|
|
|
map.SetKeyValue("mark", "mal");
|
|
EXPECT_EQ(2u, map.GetCount());
|
|
EXPECT_STREQ("mal", map.GetValueForKey("mark"));
|
|
|
|
map.RemoveKey("mark");
|
|
EXPECT_EQ(1u, map.GetCount());
|
|
EXPECT_FALSE(map.GetValueForKey("mark"));
|
|
}
|
|
|
|
TEST(NonAllocatingMapTest, Serialize) {
|
|
typedef NonAllocatingMap<4, 5, 7> TestMap;
|
|
TestMap map;
|
|
map.SetKeyValue("one", "abc");
|
|
map.SetKeyValue("two", "def");
|
|
map.SetKeyValue("tre", "hig");
|
|
|
|
EXPECT_STREQ("abc", map.GetValueForKey("one"));
|
|
EXPECT_STREQ("def", map.GetValueForKey("two"));
|
|
EXPECT_STREQ("hig", map.GetValueForKey("tre"));
|
|
|
|
const SerializedNonAllocatingMap* serialized;
|
|
size_t size = map.Serialize(&serialized);
|
|
|
|
SerializedNonAllocatingMap* serialized_copy =
|
|
reinterpret_cast<SerializedNonAllocatingMap*>(malloc(size));
|
|
ASSERT_TRUE(serialized_copy);
|
|
memcpy(serialized_copy, serialized, size);
|
|
|
|
TestMap deserialized(serialized_copy, size);
|
|
free(serialized_copy);
|
|
|
|
EXPECT_EQ(3u, deserialized.GetCount());
|
|
EXPECT_STREQ("abc", deserialized.GetValueForKey("one"));
|
|
EXPECT_STREQ("def", deserialized.GetValueForKey("two"));
|
|
EXPECT_STREQ("hig", deserialized.GetValueForKey("tre"));
|
|
}
|
|
|
|
// Running out of space shouldn't crash.
|
|
TEST(NonAllocatingMapTest, OutOfSpace) {
|
|
NonAllocatingMap<3, 2, 2> map;
|
|
map.SetKeyValue("a", "1");
|
|
map.SetKeyValue("b", "2");
|
|
map.SetKeyValue("c", "3");
|
|
EXPECT_EQ(2u, map.GetCount());
|
|
EXPECT_FALSE(map.GetValueForKey("c"));
|
|
}
|
|
|
|
TEST(NonAllocatingMapTest, ByIndex) {
|
|
NonAllocatingMap<10, 10, 3> map;
|
|
|
|
size_t index1 = map.SetKeyValue("test", "one");
|
|
EXPECT_TRUE(index1 >= 0 && index1 <= map.num_entries);
|
|
|
|
size_t index2 = map.SetKeyValue("moo", "foo");
|
|
EXPECT_TRUE(index2 >= 0 && index2 <= map.num_entries);
|
|
EXPECT_NE(index1, index2);
|
|
|
|
size_t index3 = map.SetKeyValue("blob", "kebab");
|
|
EXPECT_TRUE(index3 >= 0 && index3 <= map.num_entries);
|
|
EXPECT_NE(index2, index3);
|
|
|
|
size_t index4 = map.SetKeyValue("nogo", "full");
|
|
EXPECT_TRUE(index4 == map.num_entries);
|
|
|
|
EXPECT_STREQ("one", map.GetValueForKey("test"));
|
|
EXPECT_STREQ("foo", map.GetValueForKey("moo"));
|
|
EXPECT_STREQ("kebab", map.GetValueForKey("blob"));
|
|
|
|
map.SetValueAtIndex(index2, "booo");
|
|
EXPECT_STREQ("booo", map.GetValueForKey("moo"));
|
|
|
|
EXPECT_TRUE(map.RemoveAtIndex(index1));
|
|
EXPECT_FALSE(map.GetValueForKey("test"));
|
|
|
|
EXPECT_FALSE(map.RemoveAtIndex(map.num_entries));
|
|
EXPECT_FALSE(map.RemoveAtIndex(9999));
|
|
}
|
|
|
|
#ifndef NDEBUG
|
|
|
|
TEST(NonAllocatingMapTest, NullKey) {
|
|
NonAllocatingMap<4, 6, 6> map;
|
|
ASSERT_DEATH(map.SetKeyValue(NULL, "hello"), "");
|
|
|
|
map.SetKeyValue("hi", "there");
|
|
ASSERT_DEATH(map.GetValueForKey(NULL), "");
|
|
EXPECT_STREQ("there", map.GetValueForKey("hi"));
|
|
|
|
ASSERT_DEATH(map.GetValueForKey(NULL), "");
|
|
map.RemoveKey("hi");
|
|
EXPECT_EQ(0u, map.GetCount());
|
|
}
|
|
|
|
#endif // !NDEBUG
|
|
|
|
} // namespace google_breakpad
|