breakpad/src
Jon Turney 7ec3caf6c7 Fix Windows client ExceptionHandlerTest tests
ExceptionHandlerTest.InvalidParameterMiniDumpTest and
ExceptionHandlerTest.PureVirtualCallMiniDumpTest both also exercise a
feature that if the MiniDumpWithFullMemory MINIDUMP_TYPE is used, both
UUID.dmp and UUID-full.dmp files are written.

This is currently broken, and requesting a minidump with
MiniDumpWithFullMemory MINIDUMP_TYPE fails, as the file handle for the full
dump is not set.

Call GenerateFullDumpFile() if MiniDumpWithFullMemory is requested, to
generate a filename for the full dump file and set the file handle.

Currently GenerateFullDumpFile() also generates another UUID for the full
dump filename, so also make the private method
MinidumpGenerator::GenerateDumpFilePath() idempotent (so the same UUID is
reused)

(Note that calling Generate(|Full)DumpFile() more than once is not
permitted, so there's no behaviour where this changed the UUID to preserve)

BUG=

Change-Id: I74304f38b398f53da1c24f368dedfba8463da9e5
Reviewed-on: https://chromium-review.googlesource.com/452978
Reviewed-by: Mike Frysinger <vapier@chromium.org>
2017-03-11 20:58:29 +00:00
..
build Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd. 2014-09-10 12:47:46 +00:00
client Fix Windows client ExceptionHandlerTest tests 2017-03-11 20:58:29 +00:00
common Use NSURLSession if the min version we support is iOS 7+. 2017-03-09 16:11:07 +00:00
google_breakpad minidump: mark Read as override in derived classes 2017-02-20 18:03:14 +00:00
processor Fix segfault when interpreting bad debug_file 2017-03-08 21:31:16 +00:00
third_party libdisasm: add upstream/license details 2017-02-14 11:07:42 +00:00
tools win: Set LargeAddressAware on symupload 2017-02-28 19:27:24 +00:00
breakpad_googletest_includes.h test: allow use of system gmock/gtest libs 2016-01-25 19:27:56 -05:00
config.h.in Fix a dependency issue in automake 2016-04-12 14:55:18 -04:00