mirror of
https://git.suyu.dev/suyu/breakpad.git
synced 2026-03-14 01:46:29 +00:00
4c01a9c389
When LinuxCoreDumper fails to copy process data from a core file, it fills the return buffer with a repeated sequence of a special marker. However, MinidumpWriter doesn't know about that and may incorrectly interpret the data. In many cases, MinidumpWriter simply copies the gibberish data to the minidump, which isn't too bad. However, the gibberish data may cause MinidumpWriter to behave badly in some other cases. For example, when MinidumpWriter tries to iterate through the linked list of all loaded DSOs via the r_map field of a r_debug struct, if the linked list is filed with the special marker, the code keeps iterating through the same address. This CL addresses the issue by having LinuxCoreDumper::CopyFromProcess() returns a Boolean value to indicate if the expected data is found from the core file. MinidumpWriter can then decide how to handle that. BUG=chromium:453484 TEST=Run core2md with the test data attached to chromium:453484. R=mark@chromium.org Review URL: https://breakpad.appspot.com/4724002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1420 4c0a9323-5329-0410-9bdc-e9ce6186880e
93 lines
4.0 KiB
C++
93 lines
4.0 KiB
C++
// Copyright (c) 2012, Google Inc.
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following disclaimer
|
|
// in the documentation and/or other materials provided with the
|
|
// distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived from
|
|
// this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// linux_ptrace_dumper.h: Define the google_breakpad::LinuxPtraceDumper
|
|
// class, which is derived from google_breakpad::LinuxDumper to extract
|
|
// information from a crashed process via ptrace.
|
|
// This class was originally splitted from google_breakpad::LinuxDumper.
|
|
|
|
#ifndef CLIENT_LINUX_MINIDUMP_WRITER_LINUX_PTRACE_DUMPER_H_
|
|
#define CLIENT_LINUX_MINIDUMP_WRITER_LINUX_PTRACE_DUMPER_H_
|
|
|
|
#include "client/linux/minidump_writer/linux_dumper.h"
|
|
|
|
namespace google_breakpad {
|
|
|
|
class LinuxPtraceDumper : public LinuxDumper {
|
|
public:
|
|
// Constructs a dumper for extracting information of a given process
|
|
// with a process ID of |pid|.
|
|
explicit LinuxPtraceDumper(pid_t pid);
|
|
|
|
// Implements LinuxDumper::BuildProcPath().
|
|
// Builds a proc path for a certain pid for a node (/proc/<pid>/<node>).
|
|
// |path| is a character array of at least NAME_MAX bytes to return the
|
|
// result. |node| is the final node without any slashes. Returns true on
|
|
// success.
|
|
virtual bool BuildProcPath(char* path, pid_t pid, const char* node) const;
|
|
|
|
// Implements LinuxDumper::CopyFromProcess().
|
|
// Copies content of |length| bytes from a given process |child|,
|
|
// starting from |src|, into |dest|. This method uses ptrace to extract
|
|
// the content from the target process. Always returns true.
|
|
virtual bool CopyFromProcess(void* dest, pid_t child, const void* src,
|
|
size_t length);
|
|
|
|
// Implements LinuxDumper::GetThreadInfoByIndex().
|
|
// Reads information about the |index|-th thread of |threads_|.
|
|
// Returns true on success. One must have called |ThreadsSuspend| first.
|
|
virtual bool GetThreadInfoByIndex(size_t index, ThreadInfo* info);
|
|
|
|
// Implements LinuxDumper::IsPostMortem().
|
|
// Always returns false to indicate this dumper performs a dump of
|
|
// a crashed process via ptrace.
|
|
virtual bool IsPostMortem() const;
|
|
|
|
// Implements LinuxDumper::ThreadsSuspend().
|
|
// Suspends all threads in the given process. Returns true on success.
|
|
virtual bool ThreadsSuspend();
|
|
|
|
// Implements LinuxDumper::ThreadsResume().
|
|
// Resumes all threads in the given process. Returns true on success.
|
|
virtual bool ThreadsResume();
|
|
|
|
protected:
|
|
// Implements LinuxDumper::EnumerateThreads().
|
|
// Enumerates all threads of the given process into |threads_|.
|
|
virtual bool EnumerateThreads();
|
|
|
|
private:
|
|
// Set to true if all threads of the crashed process are suspended.
|
|
bool threads_suspended_;
|
|
};
|
|
|
|
} // namespace google_breakpad
|
|
|
|
#endif // CLIENT_LINUX_HANDLER_LINUX_PTRACE_DUMPER_H_
|