SwitchEmu/dynarmic
1
0
Fork 0
mirror of https://git.suyu.dev/suyu/dynarmic.git synced 2026-03-10 04:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

backend/x64: Temporarily avoid use of DefineValue(Argument&)

Browse Source 
Issues with inappropriate values in upper bits of values
This commit is contained in:
Merry
2020-06-27 10:51:10 +01:00
parent 337498823c
commit b1ff971a92
3 changed files with 33 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/x64/emit_x64_vector.cpp
View File

@@ -156,10 +156,7 @@ void EmitX64::EmitVectorGetElement8(EmitContext& ctx, IR::Inst* inst) {
ASSERT(args[1].IsImmediate());
const u8 index = args[1].GetImmediateU8();
if (index == 0) {
ctx.reg_alloc.DefineValue(inst, args[0]);
return;
}
// TODO: DefineValue directly on Argument for index == 0
const Xbyak::Xmm source = ctx.reg_alloc.UseXmm(args[0]);
const Xbyak::Reg32 dest = ctx.reg_alloc.ScratchGpr().cvt32();
@@ -170,6 +167,8 @@ void EmitX64::EmitVectorGetElement8(EmitContext& ctx, IR::Inst* inst) {
code.pextrw(dest, source, index / 2);
if (index % 2 == 1) {
code.shr(dest, 8);
} else {
code.and_(dest, 0xFF); // TODO: Remove when zext handling is corrected
}
}
@@ -181,10 +180,7 @@ void EmitX64::EmitVectorGetElement16(EmitContext& ctx, IR::Inst* inst) {
ASSERT(args[1].IsImmediate());
const u8 index = args[1].GetImmediateU8();
if (index == 0) {
ctx.reg_alloc.DefineValue(inst, args[0]);
return;
}
// TODO: DefineValue directly on Argument for index == 0
const Xbyak::Xmm source = ctx.reg_alloc.UseXmm(args[0]);
const Xbyak::Reg32 dest = ctx.reg_alloc.ScratchGpr().cvt32();
@@ -197,10 +193,7 @@ void EmitX64::EmitVectorGetElement32(EmitContext& ctx, IR::Inst* inst) {
ASSERT(args[1].IsImmediate());
const u8 index = args[1].GetImmediateU8();
if (index == 0) {
ctx.reg_alloc.DefineValue(inst, args[0]);
return;
}
// TODO: DefineValue directly on Argument for index == 0
const Xbyak::Reg32 dest = ctx.reg_alloc.ScratchGpr().cvt32();
@@ -222,7 +215,11 @@ void EmitX64::EmitVectorGetElement64(EmitContext& ctx, IR::Inst* inst) {
const u8 index = args[1].GetImmediateU8();
if (index == 0) {
ctx.reg_alloc.DefineValue(inst, args[0]);
// TODO: DefineValue directly on Argument for index == 0
const Xbyak::Reg64 dest = ctx.reg_alloc.ScratchGpr().cvt64();
const Xbyak::Xmm source = ctx.reg_alloc.UseXmm(args[0]);
code.movq(dest, source);
ctx.reg_alloc.DefineValue(inst, dest);
return;
}