mirror/zfs-inplace-rebalancing
1
0
Fork 1
mirror of https://github.com/markusressel/zfs-inplace-rebalancing synced 2026-02-05 05:24:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

1.5x speed increase by using cmp instead of crc32 (#61)

Browse Source 
* 2x speed increase by using cmp instead of crc32

* Remove redundant cmp check
This commit is contained in:
Adi 2025-01-18 12:48:12 +02:00 committed by GitHub
parent d190faf49c
commit 97d11fdb0b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
zfs-inplace-rebalancing.sh
View File

@ -137,25 +137,19 @@ function rebalance() {
# Linux # Linux
# file attributes # file attributes
original_checksum=$(lsattr "${file_path}") original_perms=$(lsattr "${file_path}")
# remove anything after the last space # remove anything after the last space
original_checksum=${original_checksum% *} original_perms=${original_perms% *}
# file permissions, owner, group, size, modification time # file permissions, owner, group, size, modification time
original_checksum="${original_checksum} $(stat -c "%A %U %G %s %Y" "${file_path}")" original_perms="${original_perms} $(stat -c "%A %U %G %s %Y" "${file_path}")"
# file content
original_checksum="${original_checksum} $(cksum "${file_path}")"
# file attributes # file attributes
copy_checksum=$(lsattr "${tmp_file_path}") copy_perms=$(lsattr "${tmp_file_path}")
# remove anything after the last space # remove anything after the last space
copy_checksum=${copy_checksum% *} copy_perms=${copy_perms% *}
# file permissions, owner, group, size, modification time # file permissions, owner, group, size, modification time
copy_checksum="${copy_checksum} $(stat -c "%A %U %G %s %Y" "${tmp_file_path}")" copy_perms="${copy_perms} $(stat -c "%A %U %G %s %Y" "${tmp_file_path}")"
# file content
copy_checksum="${copy_checksum} $(cksum "${file_path}")"
# remove the temporary extension
copy_checksum=${copy_checksum%"${tmp_extension}"}
elif [[ "${OSName}" == "darwin"* ]] || [[ "${OSName}" == "freebsd"* ]]; then elif [[ "${OSName}" == "darwin"* ]] || [[ "${OSName}" == "freebsd"* ]]; then
# Mac OS # Mac OS
# FreeBSD # FreeBSD
@ -163,25 +157,26 @@ function rebalance() {
# note: no lsattr on Mac OS or FreeBSD # note: no lsattr on Mac OS or FreeBSD
# file permissions, owner, group size, modification time # file permissions, owner, group size, modification time
original_checksum="$(stat -f "%Sp %Su %Sg %z %m" "${file_path}")" original_perms="$(stat -f "%Sp %Su %Sg %z %m" "${file_path}")"
# file content
original_checksum="${original_checksum} $(cksum "${file_path}")"
# file permissions, owner, group size, modification time # file permissions, owner, group size, modification time
copy_checksum="$(stat -f "%Sp %Su %Sg %z %m" "${tmp_file_path}")" copy_perms="$(stat -f "%Sp %Su %Sg %z %m" "${tmp_file_path}")"
# file content
copy_checksum="${copy_checksum} $(cksum "${file_path}")"
# remove the temporary extension
copy_checksum=${copy_checksum%"${tmp_extension}"}
else else
echo "Unsupported OS type: $OSTYPE" echo "Unsupported OS type: $OSTYPE"
exit 1 exit 1
fi fi
if [[ "${original_checksum}" == "${copy_checksum}"* ]]; then if [[ "${original_perms}" == "${copy_perms}"* ]]; then
color_echo "${Green}" "Checksum OK" color_echo "${Green}" "Attribute and permission check OK"
else else
color_echo "${Red}" "Checksum FAILED: ${original_checksum} != ${copy_checksum}" color_echo "${Red}" "Attribute and permission check FAILED: ${original_perms} != ${copy_perms}"
exit 1
fi
if cmp -s "${file_path}" "${tmp_file_path}"; then
color_echo "${Green}" "File content check OK"
else
color_echo "${Red}" "File content check FAILED"
exit 1 exit 1
fi fi
fi fi